Re: What's in git.git (stable)
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 18, 2008, 02:05 UTC
- Message-ID
- <alpine.LSU.1.00.0802180204190.30505@racer.site>
- In-Reply-To
- <20080218014301.GA6642@sigill.intra.peff.net>
Hi,
On Sun, 17 Feb 2008, Jeff King wrote:
Show 12 quoted lines
> On Mon, Feb 18, 2008 at 01:34:50AM +0000, Johannes Schindelin wrote: > > > Well, my workflow has lots of these moments. I do not even feel "oops" > > about it. More like "by the way, this needs committing _now_". > > > > So I guess I'll be the guinea pig for this patch, and if it is too > > painful, I'll just go and fix it. > > Just to be clear, this patch discards the cache after preparing the > partial index but before doing the status. This is in contrast to the > current 'master' and v1.5.4, which discard the cache _three_ times > during the status process.
... but then goes through big pains to reconstruct an index that needs as little updating as possible.
> So no, the performance will probably not be a big deal. It is better > than it has been in any released version of git.
I'll see, and report back.
IOW I think that your patch is necessary. There might be some followup work to do for me, but at the moment, your patch fixes an existing bug.
Ciao, Dscho