Re: git-status producing incorrect results

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 14, 2008, 17:02 UTC
Message-ID: <alpine.LSU.1.00.0802141700450.30505@racer.site>
In-Reply-To: <20080214165432.GA28059@coredump.intra.peff.net>

Hi,

On Thu, 14 Feb 2008, Jeff King wrote:

Show 7 quoted lines

> On Thu, Feb 14, 2008 at 04:51:04PM +0000, Johannes Schindelin wrote:
> 
> > I experienced the same bug, but when I looked in the tests, I had the 
> > impression that it tested for that very bug, and succeeded.  And I did 
> > not have time to look into it further.
> 
> Which test did you think was checking for it?

Well, I was looking at t7501-commit.sh, since I assumed that it not only _showed_ this status, but also _committed_ it. I did not even bother to try, but aborted the commit by deleting the whole commit message.

Show 12 quoted lines

> diff --git a/t/t7502-status.sh b/t/t7502-status.sh
> index b64ce30..11e5655 100755
> --- a/t/t7502-status.sh
> +++ b/t/t7502-status.sh
> @@ -128,4 +128,8 @@ test_expect_success 'status without relative paths' '
>  
>  '
>  
> +test_expect_success 'status of partial commit excluding new file in index' '
> +	git status modified
> +'
> +

That would need a redirection to "> output", and a known-good "expect", to make sure that it indeed works as expected.

Ciao, Dscho