Re: [BUG] git bisect should not expand file globs in log
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 12, 2008, 19:50 UTC
- Message-ID
- <alpine.LSU.1.00.0802121950210.3870@racer.site>
- In-Reply-To
- <200802122023.28879.elendil@planet.nl>
Hi,
does this help? (It is a really trivial patch...)
-- snipsnap -- [PATCH] bisect: use verbatim commit subject in the bisect log
Due to a typo, the commit subject was shell expanded in the bisect log. That is, if you had some shell pattern in the commit subject, bisect would happily put all matching file names into the log.
Noticed by Frans Pop.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- git-bisect.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-bisect.sh b/git-bisect.sh index 5385249..0bb51d7 100755 --- a/git-bisect.sh +++ b/git-bisect.sh @@ -131,7 +131,7 @@ bisect_write() { *) die "Bad bisect_write argument: $state" ;; esac git update-ref "refs/bisect/$tag" "$rev" - echo "# $state: "$(git show-branch $rev) >>"$GIT_DIR/BISECT_LOG" + echo "# $state: $(git show-branch $rev)" >>"$GIT_DIR/BISECT_LOG" test -z "$nolog" && echo "git-bisect $state $rev" >>"$GIT_DIR/BISECT_LOG" }
-- 1.5.4.18.gb6d712