Re: [PATCH 1/3] git-submodule - Follow top-level remote on init/update/clone
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 12, 2008, 01:10 UTC
- Message-ID
- <alpine.LSU.1.00.0802120109270.3870@racer.site>
- In-Reply-To
- <47B0EFA2.9070903@gmail.com>
Hi,
On Mon, 11 Feb 2008, Mark Levedahl wrote:
Show 18 quoted lines
> Johannes Schindelin wrote: > > > > @@ -107,7 +112,7 @@ module_clone() > > > test -e "$path" && > > > die "A file already exist at path '$path'" > > > - git-clone -n "$url" "$path" || > > > + git-clone -n -o "$remote" "$url" "$path" || > > > die "Clone of '$url' into submodule path '$path' failed" > > > } > > > > > > > If you do _that_, you will _force_ the submodule to have no "origin" > > remote. As discussed _at length_, this is not what you should do. > > The only reason to use "-o <other-nick-name>" is if you plan _not_ to > > use the same URL for the default remote. > > This *must* define the remote using the same name as flowed down from > top-level, whatever that name is.
At this point, I give up my review in despair, Dscho