[PATCH] Fix "git clone" for git:// protocol
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 9, 2008, 16:58 UTC
- Message-ID
- <alpine.LSU.1.00.0802091657000.11591@racer.site>
In the commit "Reduce the number of connects when fetching", we checked the return value of git_connect() to see if the connection was successful.
However, for the git:// protocol, there is no need to have another process, so the return value is NULL.
The thing is: git_connect() does not return at all if it fails, so we need not check the return value of git_connect().
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- builtin-fetch-pack.c | 16 ++++++---------- 1 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/builtin-fetch-pack.c b/builtin-fetch-pack.c index f401352..184782f 100644 --- a/builtin-fetch-pack.c +++ b/builtin-fetch-pack.c @@ -707,17 +707,13 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix) conn = git_connect(fd, (char *)dest, args.uploadpack, args.verbose ? CONNECT_VERBOSE : 0); - if (conn) { - get_remote_heads(fd[0], &ref, 0, NULL, 0); - - ref = fetch_pack(&args, fd, conn, ref, dest, nr_heads, heads, NULL); - close(fd[0]); - close(fd[1]); - if (finish_connect(conn)) - ref = NULL; - } else { + get_remote_heads(fd[0], &ref, 0, NULL, 0); + + ref = fetch_pack(&args, fd, conn, ref, dest, nr_heads, heads, NULL); + close(fd[0]); + close(fd[1]); + if (finish_connect(conn)) ref = NULL; - } ret = !ref; if (!ret && nr_heads) {
-- 1.5.4.1264.g42770c