Re: [msysGit] Re: [ANNOUNCE] GIT 1.5.4

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 8, 2008, 01:53 UTC
Message-ID: <alpine.LSU.1.00.0802080143440.11591@racer.site>
In-Reply-To: <4C918ADB-6FF5-458E-AC81-5683850E1FE4@zib.de>

Hi,

On Thu, 7 Feb 2008, Steffen Prohaska wrote:

Show 21 quoted lines

> On Feb 7, 2008, at 8:59 PM, Linus Torvalds wrote:
> > 
> > On Thu, 7 Feb 2008, Junio C Hamano wrote:
> > > 
> > > I think removing the license dialog is a bad idea.  You need to tell 
> > > the end-user about his rights, and one of the things is that he can 
> > > get source to git under the terms of GPLv2.  The bug is not about 
> > > showing the license, but is about refusing to install unless the end 
> > > user agrees with it.
> > 
> > Yeah. Why not just rather than the whole ok/cancel discussion, go with 
> > a single button saying "good for me!" and be done with it.
> > 
> > IOW, the license thing should be considered *informational* rather 
> > than a choice. Because to a user, that's exactly what the GPL is.
> 
> Ok, if there are no further objections, we'll do that.
> 
> Sebastian, can we easily modify the license dialog with Inno Setup? The 
> license should be displayed and a single click should be sufficient to 
> "continue".

It looks like "LicenseFile" is a special variable in InnoSetup, and it is not _that_ easy to change it to an "I am okay with it; I read it" text. Maybe something like the release notes would be good ("Source: ... Flags: isreadme")?

In any case, I think this discussion has outlived its usefulness: there are _many_ _more_ pressing issues with msysGit.

Having said that, I am really amazed that we seem to finally have picked up some Windows experts... So my hopes are high for a catch-up with git.git that will lead to an msysGit-from-git.git soon!

For example, the git-svn issue seems resolved now (thanks Simon, Christian and Mike -- I call them the "S-C-M" gang). If we can squeeze better performance out of it, all the better.

git-cheetah also appears to gather way nicely: it seems that the only obstacle is my own laziness (and admittedly, lack of time) to review the changes and push them!

Hoist the anchors, Dscho