Re: [PATCH 4/4] Add a --cover-letter option to format-patch

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 7, 2008, 00:04 UTC
Message-ID: <alpine.LSU.1.00.0802070002160.8543@racer.site>
In-Reply-To: <200802061921.58282.kumbayo84@arcor.de>

Hi,

I don't know about you, but with lines...

On Wed, 6 Feb 2008, Peter Oberndorfer wrote:

> On Mittwoch 06 Februar 2008, Daniel Barkalow wrote:
>

like this:

> > -		strlcpy(filename, output_directory, sizeof(filename) -

suffix_len);

... (when the mailer wraps the original line), comments like this...

> > +		len += sprintf(filename + len, "%d", nr);
> maybe this should be !oneline instead?
> > +	else {

... are extremely hard to spot. You could help people who are too dumb to do that easily (such as yours truly), by putting an empty line between every text you quote and your comments.

Thanks, Dscho