Re: [PATCH] git-rebase.sh: Use POSIX/Susv command substitution instead of backticks

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 5, 2008, 23:06 UTC
Message-ID: <alpine.LSU.1.00.0802052305080.8543@racer.site>
In-Reply-To: <abmfxbg3.fsf@blue.sea.net>

Hi,

On Wed, 6 Feb 2008, Jari Aalto wrote:

Show 12 quoted lines

> * Tue 2008-02-05 Johannes Schindelin <Johannes.Schindelin@gmx.de>
> * Message-Id: alpine.LSU.1.00.0802052226340.8543@racer.site
>
> > On Wed, 6 Feb 2008, Jari Aalto wrote:
> >
> >> Use redable $(<command>) syntax instead of backtics in code.  See The 
> >> Open Group Base Specifications Issue 6, IEEE Std 1003.1, 2004 Edition
> >
> > Sorry, I am not quite sure if this patch is worth it: either you want 
> > to clean this up in _all_ of our shell scripts, or you leave it.
> 
> Yes, that's the plan. This is just a start.

Again, you failed to address me. FYI my email address is johannes.schindelin@gmx.de. Thank you very much.

"This is just a start" is not good enough. First, you have to defend why this is a good change. It does not really fix anything.

And then you have to do it for all scripts in one go. Mind you, it is not really complicated: just one call to perl.

Hth, Dscho