Re: [PATCH] git-rebase.sh: Unchain the git-COMMAND into git COMMAND

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 5, 2008, 14:10 UTC
Message-ID: <alpine.LSU.1.00.0802051407540.8543@racer.site>
In-Reply-To: <8x1zzemr.fsf@blue.sea.net>

Hi,

On Tue, 5 Feb 2008, Jari Aalto wrote:

Show 17 quoted lines

> * Mon 2008-02-04 Johannes Schindelin <Johannes.Schindelin@gmx.de>
> * Message-Id: alpine.LSU.1.00.0802042050480.8543@racer.site
> > Hi,
> >
> > On Mon, 4 Feb 2008, Jari Aalto wrote:
> >
> >> -Example:       git-rebase master~1 topic
> >> +Example:       git rebase master~1 topic
> >
> > From 36e5e70e0f40cf7ca4351b8159d68f8560a2805f(Start deprecating 
> > "git-command" in favor of "git command"):
> >
> >     (For non-builtins, the "git xyzzy" format implies an extra execve(), so
> >     this script leaves those alone).
> 
> Please elaborate. I'm not sure I understand. If the git-<command> syntax
> is being phased out, it should be consistent decision accross the tools.

If you call "git xyz", but git-xyz is a script, you will exec the git wrapper first, which will then exec git-xyz. That is an unnecessary exec.

Since the places you touched are already in a git script (i.e. it was already called with PATH extended to git's libexec/ directory, if there is one), we can avoid that extra exec.

The git-<command> syntax _is_ phased out, but in several steps. Let's not do the third step before the first, otherwise we'll trip.

Ciao, Dscho