Re: [PATCH] filter-branch.sh: remove temporary directory on failure

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 30, 2008, 11:51 UTC
Message-ID: <alpine.LSU.1.00.0801301151050.23907@racer.site>
In-Reply-To: <7v3asfkgii.fsf@gitster.siamese.dyndns.org>

Hi,

On Tue, 29 Jan 2008, Junio C Hamano wrote:

Show 16 quoted lines

> Brandon Casey <casey@nrlssc.navy.mil> writes:
> 
> > Even though this directory may be useful for debugging when you 
> > encounter a problem, I wonder if the normal "error" will be _user_ 
> > error. In which case the user will adjust the command line parameters 
> > and try to rerun. Currently the user would then receive the message
> >
> >      "$tempdir already exists, please remove it"
> >
> > Then, rm -rf the tempdir, then rerun.
> >
> > Is this necessary? Maybe anyone with the know-how to debug would also 
> > have the know-how to comment out the 'trap' in the script (or direct 
> > someone asking for help on the mailing list to do so).
> 
> Makes sense to me.  Dscho?

To me, too.

Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>

Thanks, Dscho