git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Avoid running lstat(2) on the same cache entry.

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 20, 2008, 15:18 UTC
Message-ID
<alpine.LSU.1.00.0801201515060.5731@racer.site>
In-Reply-To
<15ECE22B-FCBB-4F12-919B-694E48D48E0D@zib.de>
Hi,
On Sun, 20 Jan 2008, Steffen Prohaska wrote:
Show 66 quoted lines
> On Jan 20, 2008, at 2:48 AM, Johannes Schindelin wrote:
> 
> > On Sat, 19 Jan 2008, Linus Torvalds wrote:
> > 
> > > Best time before:
> > > 
> > > 	[torvalds@woody linux]$ time git commit > /dev/null
> > > 	real    0m0.399s
> > > 	user    0m0.232s
> > > 	sys     0m0.164s
> > > 
> > > Best time after:
> > > 
> > > 	[torvalds@woody linux]$ time git commit > /dev/null
> > > 	real    0m0.254s
> > > 	user    0m0.140s
> > > 	sys     0m0.112s
> > 
> > Wow.
> > 
> > > I bet you'll see a much bigger performance improvement from this on
> > > Windows in particular.
> > 
> > I bet so, too.  Traditionally, filesystem calls are painfully slow on
> > Windows.
> > 
> > But I cannot test before Monday, so I would not be mad if somebody else
> > could perform some tests on Windows.
> 
> Here are timings for Windows XP running in a virtual machine on a
> Laptop.  The work tree contains 7k files.  I stripped user and
> sys times because they are apparently meaningless for MINGW.
> 
> Best time before:
> 
>    $ time git commit >/dev/null
>    real    0m1.662s
> 
> Best time after:
> 
>    $ time git commit >/dev/null
>    real    0m1.196s
> 
> The absolute time improvement is obviously larger, although the
> relative improvement is slightly smaller than in Linus' example.
> 
> 
> And here are the timings for the host system, which is Mac OS X,
> on the same work tree.
> 
> Best time before:
> 
>    $ time git commit >/dev/null
>    real    0m0.571s
>    user    0m0.332s
>    sys     0m0.237s
> 
> Best time after:
> 
>    $ time git commit >/dev/null
>    real    0m0.463s
>    user    0m0.273s
>    sys     0m0.186s
> 
> Interestingly, the relative improvements are even smaller on Mac
> OS X.
Still, nothing to spit at.

FWIW I have made two patches which should be probably folded into Linus' patch; I will post them as a reply.

Ciao, Dscho

Previous: Steffen ProhaskaNext: Johannes Schindelin
Message 14 of 26 in “Updated in-memory index cleanup”
  1. Linus TorvaldsJan 19, 2008
  2. index: be careful when handling long namesJunio C Hamano, Jan 19, 2008
  3. Avoid running lstat(2) on the same cache entry.Junio C Hamano, Jan 19, 2008
  4. Linus TorvaldsJan 19, 2008
  5. Linus TorvaldsJan 19, 2008
  6. Linus TorvaldsJan 20, 2008
  7. Linus TorvaldsJan 20, 2008
  8. Johannes SchindelinJan 20, 2008
  9. Linus TorvaldsJan 20, 2008
  10. Steffen ProhaskaJan 20, 2008
  11. Johannes SchindelinJan 20, 2008
  12. Junio C HamanoJan 21, 2008
  13. Steffen ProhaskaJan 20, 2008
  14. Johannes SchindelinJan 20, 2008
  15. Also use unpack_trees() in do_diff_cache()Johannes Schindelin, Jan 20, 2008
  16. Linus TorvaldsJan 20, 2008
  17. Linus TorvaldsJan 20, 2008
  18. Johannes SchindelinJan 20, 2008
  19. Linus TorvaldsJan 20, 2008
  20. Johannes SchindelinJan 21, 2008
  21. Try to resurrect the handling for 'diff-index -m'Johannes Schindelin, Jan 20, 2008
  22. Linus TorvaldsJan 20, 2008
  23. Brian DowningJan 20, 2008
  24. Steffen ProhaskaJan 20, 2008
  25. Linus TorvaldsJan 20, 2008
  26. Johannes SchindelinJan 20, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.