git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http-push: fix double free()

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 18, 2008, 14:54 UTC
Message-ID
<alpine.LSU.1.00.0801181454400.5731@racer.site>
In-Reply-To
<20080118063417.GB22089@glandium.org>
Hi,
On Fri, 18 Jan 2008, Mike Hommey wrote:
Show 8 quoted lines
> On Thu, Jan 17, 2008 at 07:45:11PM +0000, Johannes Schindelin wrote:
> > 
> > There was an extra free(url) in remote_exists() (both if clauses before 
> > that contain a free(url) already), which resulted in a crash on Windows.
> 
> Mmmmmm the free(url) you remove has been added in 3a462bc9 and the 
> free(url) in the if clauses before have been removed in the same commit. 
> I fail to see how that could lead to a double free().

Yes, I confirm that my "fix" is wrong, because it was based on an _obsolete_ source tree. Git-1.5.4-rc3-preview20080113.exe of msysGit appears not to have a problem with HTTP pushing.

Sorry for the noise, Dscho

Previous: Johannes Schindelin
Message 4 of 4 in “http-push: fix double free()”
  1. http-push: fix double free()Johannes Schindelin, Jan 17, 2008
  2. Mike HommeyJan 18, 2008
  3. Johannes SchindelinJan 18, 2008
  4. Johannes SchindelinJan 18, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.