Re: [PATCH v2] Do not show "diff --git" metainfo with --no-prefix
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 17, 2008, 15:12 UTC
- Message-ID
- <alpine.LSU.1.00.0801171511080.5731@racer.site>
- In-Reply-To
- <20080117150306.GB2816@coredump.intra.peff.net>
Hi,
On Thu, 17 Jan 2008, Jeff King wrote:
Show 12 quoted lines
> On Thu, Jan 17, 2008 at 09:49:14AM -0500, Jeff King wrote: > > > Hmm. I happen to set my "meta" color to something a little less > > attention-grabbing (magenta), and I find the alternate coloring to be > > a nice visual indicator of "nothing happened on this line". I can see > > how bold would be very distracting, though. Perhaps there should be a > > color.diff.unimportant? > > BTW, here is the fix to at least color it as plain (it is a little > larger than the one line it needs to be because it cleans up the > variable name "set", which is what caused this confusion in the first > place).
Ah, that explains it! Your patch looks good to me.
Thanks, Dscho
P.S.:
Show 8 quoted lines
> @@ -586,7 +587,6 @@ static void fn_out_consume(void *priv, char *line, unsigned long len)
> }
>
> if (len < ecbdata->nparents) {
> - set = reset;
> emit_line(reset, reset, line, len);
> return;
> }I wonder what I wanted to achieve with that ;-)