Re: [PATCH] Fix the MacOS X compile of gitk by pinching po2msg.sh from git-gui

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 9, 2008, 14:06 UTC
Message-ID: <alpine.LSU.1.00.0801091404040.31053@racer.site>
In-Reply-To: <20080109135249.GA12869@hashpling.org>

Hi,

On Wed, 9 Jan 2008, Charles Bailey wrote:

Show 11 quoted lines

> On Wed, Jan 09, 2008 at 01:40:46PM +0000, Johannes Schindelin wrote:
> 
> > On Wed, 9 Jan 2008, Charles Bailey wrote:
> > 
> > > --- snip ---
> > 
> > Since gitk and git-gui are separate projects (pulled at irregular 
> > intervals into git.git), your patch looks sane, but would be better 
> > done as a patch against gitk.git.
> 
> I'm sorry, I think I knew this once, but had forgotten.

Oh, my critique was not meant as harsh as it was apparently received: for reviewing purposes, your way was perfect, as it shows your intent better than the technically correct patch.

All I'm saying is that you should send the (verbose) patch, too, possibly referring to the smaller patch in the space between the three dashes and the diffstat.

(I would also prefix this patch with "gitk:", instead of writing "of gitk", so that people reading the log of git.git get a better idea what this is about.)

Ciao, Dscho