Re: [PATCH] Having keywords without value is not a global error.
- From
- Steven Drake <sdrake@xnet.co.nz>
- Date
- Feb 26, 2010, 05:44 UTC
- Message-ID
- <alpine.LNX.2.00.1002261838360.8597@vqena.qenxr.bet.am>
- In-Reply-To
- <7vk4u0efxy.fsf@alter.siamese.dyndns.org>
On Thu, 25 Feb 2010, Junio C Hamano wrote:
Show 30 quoted lines
> Steven Drake <sdrake@xnet.co.nz> writes:
>
> > It is not a good Idea to give a config_error for _any_ keyword without a
> > value as it means that
> >
> > [section]
> > keyword
> >
> > sytle can not be using for setting bool type keyword.
> >
> > Signed-off-by: Steven Drake <sdrake@xnet.co.nz>
> > ---
> > builtin/init-db.c | 2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/builtin/init-db.c b/builtin/init-db.c
> > index 9273942..edc40ff 100644
> > --- a/builtin/init-db.c
> > +++ b/builtin/init-db.c
> > @@ -170,8 +170,6 @@ static void copy_templates(const char *template_dir)
> >
> > static int git_init_db_config(const char *k, const char *v, void *cb)
> > {
> > - if (!v)
> > - return config_error_nonbool(k);
> > if (!strcmp(k, "init.templatedir"))
> > return git_config_pathname(&init_db_template_dir, k, v);
>
> But then don't you need to catch init.templatedir does have a string
> value?Yes, but the change dose not touch that test, it removes two lines that I can't remember why a put there.
-- Steven