git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] Use $(git rev-parse --show-toplevel) in cd_to_toplevel()

From
SDSteven Drake <sdrake@xnet.co.nz>
Date
Jan 11, 2010, 07:23 UTC
Message-ID
<alpine.LNX.2.00.1001112022190.8842@vqena.qenxr.bet.am>
In-Reply-To
<alpine.LNX.2.00.1001102016380.2560@vqena.qenxr.bet.am>
 as it gives the absolute (aka "physical") path of the toplevel directory
 and 'cd -P' is not supported by all shell implementations.
See NetBSD PR/42168.
http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=42168
---
This is a revision of my original patch after the input from Jonathan.
---
 git-sh-setup.sh |   18 ++++--------------
 1 files changed, 4 insertions(+), 14 deletions(-)
diff --git a/git-sh-setup.sh b/git-sh-setup.sh
index dfcb807..4ecc578 100755
--- a/git-sh-setup.sh
+++ b/git-sh-setup.sh
@@ -120,20 +120,10 @@ is_bare_repository () {
 }
 
 cd_to_toplevel () {
-	cdup=$(git rev-parse --show-cdup)
-	if test ! -z "$cdup"
-	then
-		# The "-P" option says to follow "physical" directory
-		# structure instead of following symbolic links.  When cdup is
-		# "../", this means following the ".." entry in the current
-		# directory instead textually removing a symlink path element
-		# from the PWD shell variable.  The "-P" behavior is more
-		# consistent with the C-style chdir used by most of Git.
-		cd -P "$cdup" || {
-			echo >&2 "Cannot chdir to $cdup, the toplevel of the working tree"
-			exit 1
-		}
-	fi
+	cdup=$(git rev-parse --show-toplevel) && cd "$cdup" || {
+		echo >&2 "Cannot chdir to $cdup, the toplevel of the working tree"
+		exit 1
+	}
 }
 
 require_work_tree () {
-- 
1.6.4
Previous: Steven DrakeNext: Junio C Hamano
Message 4 of 7 in “Use $(git rev-parse --show-toplevel) in cd_to_toplevel()”
  1. 2/2 Use $(git rev-parse --show-toplevel) in cd_to_toplevel()Steven Drake, Jan 10, 2010
  2. Jonathan NiederJan 10, 2010
  3. Steven DrakeJan 11, 2010
  4. 2/2 Use $(git rev-parse --show-toplevel) in cd_to_toplevel()Steven Drake, Jan 11, 2010
  5. Junio C HamanoJan 11, 2010
  6. Steven DrakeJan 11, 2010
  7. Junio C HamanoJan 11, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.