Re: What's cooking in git.git (Dec 2009, #01; Tue, 01)

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Dec 2, 2009, 04:50 UTC
Message-ID: <alpine.LNX.2.00.0912012340060.14365@iabervon.org>
In-Reply-To: <7vaay2tkfh.fsf@alter.siamese.dyndns.org>

On Tue, 1 Dec 2009, Junio C Hamano wrote:

Show 14 quoted lines

> * sr/vcs-helper (2009-11-18) 12 commits
>   (merged to 'next' on 2009-11-27 at 83268ab)
>  + Add Python support library for remote helpers
>  + Basic build infrastructure for Python scripts
>  + Allow helpers to report in "list" command that the ref is unchanged
>  + Fix various memory leaks in transport-helper.c
>  + Allow helper to map private ref names into normal names
>  + Add support for "import" helper command
>  + Allow specifying the remote helper in the url
>  + Add a config option for remotes to specify a foreign vcs
>  + Allow fetch to modify refs
>  + Use a function to determine whether a remote is valid
>  + Allow programs to not depend on remotes having urls
>  + Fix memory leak in helper method for disconnect

The bottom one here now needs another hunk that reverts a free of the same memory (including in cases that this series will need to keep it) that snuck in unannounced with ef08ef9ea0a271e5be5844408d2496a946d6e8d9.

diff --git a/transport-helper.c b/transport-helper.c
index 5078c71..d729146 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -72,7 +72,6 @@ static int disconnect_helper(struct transport 
*transport)
                free(data->helper);
                data->helper = NULL;
        }
-       free(data);
        return 0;
 }