Re: [PATCH 07/13] Add a config option for remotes to specify a foreign vcs

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Aug 5, 2009, 22:09 UTC
Message-ID: <alpine.LNX.2.00.0908051750270.2147@iabervon.org>
In-Reply-To: <alpine.DEB.1.00.0908052349250.8306@pacific.mpi-cbg.de>

On Wed, 5 Aug 2009, Johannes Schindelin wrote:

Show 14 quoted lines

> Hi,
> 
> On Wed, 5 Aug 2009, Sverre Rabbelier wrote:
> 
> > On Wed, Aug 5, 2009 at 14:20, Johannes 
> > Schindelin<Johannes.Schindelin@gmx.de> wrote:
> > > I actually would rather have "svn-http://something" because it tells 
> > > me right away and in red letters what is happening.
> > 
> > I don't know if this is only for ssh, but wouldn't
> > "http+svn://something" be very recognisable?
> 
> Problem: on Windows, we cannot name the helper git-remote-http+svn: "+" is 
> not an allowed character in a filename.

Also, the ssh thing is "svn+ssh", so it should be "svn+http".

The transport code could know that, if there's a + before the colon, the relevant part is before the +; I think the svn helper should have to take care of whatever access to svn is requested (perhaps itself using a transport-layer protocol helper, and if you say "svn+uucp://something", it should be up to the svn helper to tell you you're nuts, not git failing to find a svn+uucp helper. In particular, if the svn helper uses a library to do its network access, the URLs it can handle may vary arbitrarily, even when you're not changing the package with git-remote-svn in it, so it shouldn't be a matter of what names the svn helper is available under in the filesystem.

In any case, we do want to support SVN repos at "svn+ssh://something" somehow, and I think users will go crazy if it isn't either sticking that in the URL or also setting another option to "svn" (the latter probably being unfortunate to require).

	-Daniel
*This .sig left intentionally blank*