git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-1.6.2-rc2 problems on t4034-diff-words.sh

From
BGBoyd Lynn Gerber <gerberb@zenez.com>
Date
Feb 27, 2009, 19:24 UTC
Message-ID
<alpine.LNX.2.00.0902271216090.19082@suse104.zenez.com>
In-Reply-To
<alpine.DEB.1.00.0902271936090.6600@intel-tinevez-2-302>

Thanks for your assistence. I try to test each version before release. So I want to make sure no changes have broken things.

On Fri, 27 Feb 2009, Johannes Schindelin wrote:
> On Fri, 27 Feb 2009, Boyd Lynn Gerber wrote:
>> I just download and started to test this on SCO OpenServer 6.0.mp4
>
> Oh wow.  SCO...

Yes, I still have to support some SCO OS's. I use git on all my OS's. So I want to make sure it works on all of them.

Show 6 quoted lines
> But as I did not forget your kind words, I'll try to help.
>
>> * FAIL 6: use regex supplied by driver
>>
>>
>>                 word_diff --color-words

Does the test suite use bash as it's shell? I seem to have to use bash now to run the test. I do not remember having to use bash on earlier 1.6.0

> It might be a regex related issue.  Could you
>
> - run the test with -i -v (and if that does not help, "sh -x t...")?
I have to use bash to run the test or I get

$ ./t4034-diff-words.sh ./t4034-diff-words.sh: syntax error at line 52: `(' unexpected

But if I run
$ bash ./t4034-diff-words.sh
*   ok 1: setup
*   ok 2: word diff with runs of whitespace
*   ok 3: word diff with a regular expression
*   ok 4: set a diff driver
*   ok 5: option overrides .gitattributes
* FAIL 6: use regex supplied by driver
                 word_diff --color-words
*   ok 7: set diff.wordRegex option
*   ok 8: command-line overrides config
* FAIL 9: .gitattributes override config
                 word_diff --color-words
*   ok 10: remove diff driver regex
*   ok 11: use configured regex
* FAIL 12: test parsing words for newline
                 word_diff --color-words="a+"
* FAIL 13: test when words are only removed at the end
                 word_diff --color-words=.
* failed 4 among 13 test(s)
$ bash ./t4034-diff-words.sh -i -v
Initialized empty Git repository in /tmp/git-1.6.2.rc2/t/trash 
directory.t4034-diff-words/.git/
* expecting success:
         git config diff.color.old red
         git config diff.color.new green
*   ok 1: setup
* expecting success:
         word_diff --color-words
*   ok 2: word diff with runs of whitespace
* expecting success:
         word_diff --color-words="[a-z]+"
*   ok 3: word diff with a regular expression
* expecting success:
         git config diff.testdriver.wordRegex "[^[:space:]]" &&
         cat <<EOF > .gitattributes
pre diff=testdriver
post diff=testdriver
EOF
*   ok 4: set a diff driver
* expecting success:
         word_diff --color-words="[a-z]+"
*   ok 5: option overrides .gitattributes
* expecting success:
         word_diff --color-words
Binary files expect and output.decrypted differ
* FAIL 6: use regex supplied by driver
                 word_diff --color-words
Binary files expect and output.decrypted differ
* FAIL 6: use regex supplied by driver
                 word_diff --color-words
>
> - try with "make COMPAT_FLAGS=-Icompat/regex COMPAT_OBJS=compat/regex/regex.o"?
$ gmake COMPAT_FLAGS=-Icompat/regex COMPAT_OBJS=compat/regex/regex.o
     CC compat/regex/regex.o
     AR libgit.a
     LINK git-fast-import
Undefined                       first referenced
symbol                              in file
git_fopen                           fast-import.o
git_vsnprintf                       fast-import.o
git_snprintf                        fast-import.o
UX:ld: ERROR: Symbol referencing errors. No output written to 
git-fast-import
gmake: *** [git-fast-import] Error 1
-- 
Boyd Gerber <gerberb@zenez.com> 801 849-0213
ZENEZ	1042 East Fort Union #135, Midvale Utah  84047
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 3 of 7 in “git-1.6.2-rc2 problems on t4034-diff-words.sh”
  1. Boyd Lynn GerberFeb 27, 2009
  2. Johannes SchindelinFeb 27, 2009
  3. Boyd Lynn GerberFeb 27, 2009
  4. Johannes SchindelinFeb 27, 2009
  5. Junio C HamanoFeb 27, 2009
  6. Boyd Lynn GerberFeb 27, 2009
  7. Boyd Lynn GerberFeb 27, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.