Re: [PATCH 3/5] Add option for using a foreign VCS

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Mar 25, 2009, 18:46 UTC
Message-ID: <alpine.LNX.1.00.0903251442200.19665@iabervon.org>
In-Reply-To: <7vhc1h5vkt.fsf@gitster.siamese.dyndns.org>

On Wed, 25 Mar 2009, Junio C Hamano wrote:

Show 18 quoted lines

> Daniel Barkalow <barkalow@iabervon.org> writes:
> 
> >> > -	if (!prefixcmp(url, "rsync:")) {
> >> > +	if (remote && remote->foreign_vcs) {
> >> > +	} else if (!prefixcmp(url, "rsync:")) {
> >> 
> >> 	if (...) {
> >>         	; /* empty */
> >> 	} else ...
> >
> > I don't think I've ever tried writing an empty block for git before. It's 
> > braces containing a semicolon and comment? (Of course, the reason I wrote 
> > this one this way is so that the next patch could put two "+" lines in 
> > there and have no "-" lines)
> 
> Wasn't a serious "this has to be the final style" suggestion, but more
> about "what do you mean by this?  are you going to add more code here in
> the later round?" question.

Ah, yes, I do intend to add code there subsequently, and this is just a placeholder so that it returns a correctly-constructed struct which doesn't support any operations until those operations are added.

	-Daniel
*This .sig left intentionally blank*