Re: [PATCH 3/7] git push: New options --matching and --current
- From
Daniel Barkalow <barkalow@iabervon.org>
- Date
- Mar 9, 2009, 23:49 UTC
- Message-ID
- <alpine.LNX.1.00.0903091938150.19665@iabervon.org>
- In-Reply-To
- <1236638151-6465-4-git-send-email-finnag@pvv.org>
On Mon, 9 Mar 2009, Finn Arne Gangstad wrote:
Show 17 quoted lines
> diff --git a/transport.h b/transport.h
> index 6bbc1a8..b897d0c 100644
> --- a/transport.h
> +++ b/transport.h
> @@ -34,6 +34,15 @@ struct transport {
> #define TRANSPORT_PUSH_DRY_RUN 4
> #define TRANSPORT_PUSH_MIRROR 8
> #define TRANSPORT_PUSH_VERBOSE 16
> +#define TRANSPORT_PUSH_MATCHING 32
> +#define TRANSPORT_PUSH_CURRENT 64
> +/**
> + * All push flags that imply a certain set of refspecs to be pushed must
> + * be combined into TRANSPORT_PUSH_MODE_MASK
> + **/
> +#define TRANSPORT_PUSH_MODE_MASK \
> + (TRANSPORT_PUSH_ALL | TRANSPORT_PUSH_MIRROR | TRANSPORT_PUSH_MATCHING | \
> + TRANSPORT_PUSH_CURRENT)It's kind of odd that you define these flags as TRANSPORT_PUSH_*, but implement them before entering transport_push(). I'm not sure which is right, but the combination is odd. I think just taking care of it in builtin-push with flags or options defined there is probably the best thing, currently.
-Daniel *This .sig left intentionally blank*