Re: [PATCH] remote.c: correct the check for a leading '/' in a remote name
- From
Daniel Barkalow <barkalow@iabervon.org>
- Date
- Oct 14, 2008, 20:35 UTC
- Message-ID
- <alpine.LNX.1.00.0810141633321.19665@iabervon.org>
- In-Reply-To
- <J-KL1Cgc2b78Lced5uBNDhP0MHdg91do73K_0waicFQYbDZHjYkocw@cipher.nrlssc.navy.mil>
On Tue, 14 Oct 2008, Brandon Casey wrote:
Show 13 quoted lines
> This test is supposed to disallow remote entries in the config file of the > form: > > [remote "/foobar"] > ... > > The leading slash in '/foobar' is not acceptable. > > Instead it was incorrectly testing that the subkey had no leading '/', which > had no effect since the subkey pointer was made to point at a '.' in the > preceding lines. > > Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Good catch; looks like I was checking for a mistake that nobody ever makes, but it's still good to check.
Acked-by: Daniel Barkalow <barkalow@iabervon.org>