Re: [PATCH] Only use GIT_CONFIG in "git config", not other programs
- From
Daniel Barkalow <barkalow@iabervon.org>
- Date
- Jul 15, 2008, 21:46 UTC
- Message-ID
- <alpine.LNX.1.00.0807151733430.19665@iabervon.org>
- In-Reply-To
- <bd6139dc0807151056q61a9379l84761fe021d4541c@mail.gmail.com>
On Tue, 15 Jul 2008, Sverre Rabbelier wrote:
Show 16 quoted lines
> On Mon, Jun 30, 2008 at 9:37 AM, Daniel Barkalow <barkalow@iabervon.org> wrote:
> > @@ -611,31 +613,28 @@ int git_config(config_fn_t fn, void *data)
> > {
> > int ret = 0;
> > char *repo_config = NULL;
> > - const char *home = NULL, *filename;
> > + const char *home = NULL;
> >
> > /* $GIT_CONFIG makes git read _only_ the given config file,
> > * $GIT_CONFIG_LOCAL will make it process it in addition to the
> > * global config file, the same way it would the per-repository
> > * config file otherwise. */
>
> I noticed today while looking at config.c (because of the 'git config
> oddity' thread) that this reference to GIT_CONFIG_LOCAL was not
> removed?Actually, it looks like that whole comment is obsolete; only builtin-config.c cares about any of this stuff.
Show 5 quoted lines
> On latest next:
> $ grep GIT_CONFIG_LOCAL *
> config.c: * $GIT_CONFIG_LOCAL will make it process it in addition to the
> git-svn: my $file = $ENV{GIT_CONFIG} || $ENV{GIT_CONFIG_LOCAL} ||
> git-svn.perl: my $file = $ENV{GIT_CONFIG} || $ENV{GIT_CONFIG_LOCAL} ||I'm not sure if git-svn is doing the right thing here, either.
-Daniel *This .sig left intentionally blank*