git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] clone: make sure we support the transport type

From
Daniel Barkalow <barkalow@iabervon.org>
Date
May 27, 2008, 17:49 UTC
Message-ID
<alpine.LNX.1.00.0805271334490.19665@iabervon.org>
In-Reply-To
<20080527163027.GB11865@glandium.org>
On Tue, 27 May 2008, Mike Hommey wrote:
Show 8 quoted lines
> On Tue, May 27, 2008 at 10:28:43AM -0400, Jeff King wrote:
> > If we use an unsupported transport (e.g., http when curl
> > support is not compiled in), transport_get reports an error
> > to the user, but we still get a transport object. We need to
> > manually check and abort the clone process at that point, or
> > we end up with a segfault.
> 
> Shouldn't transport_get return NULL in such a situation, instead ?

Perhaps, but we would still want to account for the possibility of a transport that only supports pushing or something like that, and therefore is available for the URL but isn't suitable for clone.

	-Daniel
*This .sig left intentionally blank*
Previous: Mike HommeyNext: Daniel Barkalow
Message 4 of 5 in “Segfault when cloning http:// without libcurl”
  1. Thomas RastMay 27, 2008
  2. clone: make sure we support the transport typeJeff King, May 27, 2008
  3. Mike HommeyMay 27, 2008
  4. Daniel BarkalowMay 27, 2008
  5. Daniel BarkalowMay 27, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.