Re: [PATCH 4/8] Add a function to set a non-default work tree

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Apr 22, 2008, 03:47 UTC
Message-ID: <alpine.LNX.1.00.0804212340590.19665@iabervon.org>
In-Reply-To: <7v3apeagxj.fsf@gitster.siamese.dyndns.org>

On Mon, 21 Apr 2008, Junio C Hamano wrote:

Show 15 quoted lines

> Daniel Barkalow <barkalow@iabervon.org> writes:
> 
> > On Sat, 19 Apr 2008, Junio C Hamano wrote:
> > ...
> >> How should the setting of new work tree from sideways using this interface
> >> interact with bareness of the repository?
> >
> > I'm only using it before any initialization and when I'm going to force 
> > the repository (which doesn't even exist yet; I haven't set git_dir let 
> > alone created it, let alone looked at its configuration) to be bare, so I 
> > hadn't considered that.
> 
> That is not quite an explanation that builds confidence in a patch that
> adds a generic-sounding helper function that could be called by later
> callers.  Doesn't it have a very tempting name for people to call?

My latest version has it die() if you've gotten meaningfully far in initializing the repository state. I'm also not sure there's a tempting use case for it aside for in setup code where it clearly works, at least until we've got support for dealing with multiple working trees in the same process or something of that sort. But, in any case, it'll now fail fast and obviously outside of what I've planned for.

	-Daniel
*This .sig left intentionally blank*