Re: [PATCH 11/11] Support bundles in builtin-clone

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Mar 9, 2008, 21:59 UTC
Message-ID: <alpine.LNX.1.00.0803091755530.19665@iabervon.org>
In-Reply-To: <alpine.LSU.1.00.0803092155450.3975@racer.site>

On Sun, 9 Mar 2008, Johannes Schindelin wrote:

Show 33 quoted lines

> Hi,
> 
> On Sun, 9 Mar 2008, Daniel Barkalow wrote:
> 
> > On Sun, 9 Mar 2008, Johannes Schindelin wrote:
> > 
> > > On Sat, 8 Mar 2008, Johannes Schindelin wrote:
> > > 
> > > > This forward-ports c6fef0bb(clone: support cloning full bundles) to 
> > > > the builtin clone.
> > > > 
> > > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > > > ---
> > > 
> > > Wow... Is this a new send-email feature?  I did not send this email...
> > 
> > Nope, it's an old format-patch feature. format-patch generates the 
> > messages with the From: being the commit author, and my MTA doesn't 
> > complain about the fact that I'm sending email with some entirely 
> > different From:. It would probably be more clever to have format-patch 
> > use the committer or the current user as the From:, and put an 
> > additional From: in the message body with the author if it's not the 
> > email From:.
> 
> I think that makes sense.
> 
> > Of course, you did sort of send that email 
> > (http://permalink.gmane.org/gmane.comp.version-control.git/75743).
> 
> Sort of.
> 
> Of course, I am okay with it, but I consider the From: issue a real bug in 
> send-email (or format-patch, if you want).

Agreed; (format-patch, I didn't use send-email). But I don't understand the flow control in pretty.c nearly well enough to fix it right now. It lists the author in the headers, like all of the log output formats, and doesn't then have the author available in the body, afaict.

	-Daniel
*This .sig left intentionally blank*