Re: [PATCH] Set proxy override with http_init()

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Feb 27, 2008, 19:59 UTC
Message-ID: <alpine.LNX.1.00.0802271454390.19665@iabervon.org>
In-Reply-To: <1204097780-29581-1-git-send-email-mh@glandium.org>

On Wed, 27 Feb 2008, Mike Hommey wrote:

Show 8 quoted lines

> In transport.c, proxy setting (the one from the remote conf) was set through
> curl_easy_setopt() call, while http.c already does the same with the
> http.proxy setting. We now just use this infrastructure instead, and make
> http_init() now take the proxy url as argument.
> 
> At the same time, we make get_http_walker() take a proxy argument too, and
> pass it to http_init(), which makes remote defined proxy be used for more
> than get_refs_via_curl().

It's a good idea, but maybe http_init() (and the call chain leading up to it) should take the struct remote, so that it can get anything else you might also have there in the future? For that matter, is it intentional that http-push ignore the proxy setting, which is equally available in http-push, but not used? If so, it should probably get a comment.

	-Daniel
*This .sig left intentionally blank*