Re: [PATCH 2/2] Improve collection of information for format-patch --cover-letter

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Feb 26, 2008, 16:27 UTC
Message-ID: <alpine.LNX.1.00.0802261123170.19024@iabervon.org>
In-Reply-To: <7v1w70h96u.fsf@gitster.siamese.dyndns.org>

On Mon, 25 Feb 2008, Junio C Hamano wrote:

Show 7 quoted lines

> Daniel Barkalow <barkalow@iabervon.org> writes:
> 
> > ... Note that the single boundary test is empirical, not 
> > theoretical; even a -2 limiting condition will give a diffstat if there's 
> > only one boundary commit in this particular case.
> 
> It is unclear what "a -2 limiting condition" means here...

Like "git format-patch -2". What is that actually called?

Show 10 quoted lines

> > @@ -962,7 +957,15 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
> >  
> >  	if (prepare_revision_walk(&rev))
> >  		die("revision walk setup failed");
> > +	rev.boundary = 1;
> >  	while ((commit = get_revision(&rev)) != NULL) {
> > +		if (commit->object.flags & BOUNDARY) {
> > +			fprintf(stderr, "Boundary %s\n", sha1_to_hex(commit->object.sha1));
> 
> Leftover debugging?

That last line, yes. I need a checkpatch for new uses of stderr or something.

	-Daniel
*This .sig left intentionally blank*