Re: [PATCH 2/2] Add support for url aliases in config files

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Feb 25, 2008, 04:30 UTC
Message-ID: <alpine.LNX.1.00.0802242319200.19024@iabervon.org>
In-Reply-To: <7vwsotoey8.fsf@gitster.siamese.dyndns.org>

On Sun, 24 Feb 2008, Junio C Hamano wrote:

Show 18 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Daniel Barkalow <barkalow@iabervon.org> writes:
> >
> >> [url "rewritten"]
> >> 	insteadOf = "original"
> >
> > That's much clearer than anything I've seen in this thread which
> > one is the one you cannot use yourself and which one is what you
> > have to use to get it to work.
> 
> Although I am willing to step in when they need help, I usually
> try not to finish up other people's patches, especially when I
> know they are capable.
> 
> But I wanted to take 'next' into a shape as close to the -rc1 as
> possible early, so here is my stab at it.  This will be in 'next'
> tonight.

Thanks; that's exactly what I would have done (assuming I didn't miss places like last time). Except that it should say that it's still undefined if you use:

        [url "foo"]
                insteadOf = "baz"
        [url "bar"]
                insteadOf = "baz/sub"

in that you can't predict whether "baz/sub/a" will be "bar/a" or "foo/sub/a". This is actually what I'm most concerned about, since there is actually a logical expectation (the one that matches more will be used in preference to the less specific one), but that's not implemented. Someday, we'll probably want to implement it, and that'll change the behavior of this particular case.

	-Daniel
*This .sig left intentionally blank*