Re: [PATCH] Validate nicknames of remote branches to prohibit confusing ones
- From
Daniel Barkalow <barkalow@iabervon.org>
- Date
- Feb 16, 2008, 03:11 UTC
- Message-ID
- <alpine.LNX.1.00.0802152209560.13593@iabervon.org>
- In-Reply-To
- <7vskztg8rr.fsf@gitster.siamese.dyndns.org>
On Fri, 15 Feb 2008, Junio C Hamano wrote:
Show 19 quoted lines
> Daniel Barkalow <barkalow@iabervon.org> writes: > > > The original problem was that the parsers for configuration files were > > getting confused by seeing as nicknames remotes that involved > > directory-changing characters. In particular, the branches config file > > for ".." was particularly mystifying on platforms that can open > > directories and read odd data from them. > > > > The validation function was written by Junio Hamano (with a typo > > corrected). > > > > Signed-off-by: Daniel Barkalow <barkalow@iabervon.org> > > --- > > I was sort of expecting you to just put this in yourself, but since you > > haven't, I wrote it up as an actual patch and fixed the polarity of the > > test for slashes. > > Thanks. I am bogged down in day-job these days and have been > down-sick for the past 36 hours.
No problem. It's an easy enough patch, and the test suite found the bug in the original version. I just wanted to make sure it didn't get forgotten on account of never getting a patch emailled to the list.
-Daniel *This .sig left intentionally blank*