Re: [PATCH 7/9] Export create_branch() from builtin-branch.c

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Feb 5, 2008, 20:39 UTC
Message-ID: <alpine.LNX.1.00.0802042139170.13593@iabervon.org>
In-Reply-To: <alpine.LSU.1.00.0802050136440.8543@racer.site>

On Tue, 5 Feb 2008, Johannes Schindelin wrote:

Show 15 quoted lines

> Hi,
> 
> On Mon, 4 Feb 2008, Daniel Barkalow wrote:
> 
> > You can also create branches, in exactly the same way, with checkout -b.
> > 
> > Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
> > ---
> >  builtin-branch.c |    4 ++--
> >  cache.h          |    4 ++++
> 
> Note that builtin-branch.c is not part of libgit.a, so you are only moving 
> the declaration into the "libgit" part.
> 
> Maybe it would be better to move this function, say, into refs.c?

I think it's actually time to start a branch.{c,h} library file for operations that deal with the porcelain-ish information about branches. This would go there, and a function to discard MERGE_HEAD and similar files (whatever they are, which isn't currently collected anywhere authoritative). Probably also most of the other stuff that should be shared between reset and checkout, too, and functions should probably migrate there from builtin-branch and builtin-checkout as they become needed, leaving the builtin-* code as command-line parsing and calls to these functions. In any case, I'll start with this.

	-Daniel
*This .sig left intentionally blank*