git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] t/perf/run: Use proper "--get-regexp", not "--get-regex"

From
Robert P. J. Day <rpjday@crashcourse.ca>
Date
Jun 3, 2018, 10:14 UTC
Message-ID
<alpine.LFD.2.21.1806030613080.7681@localhost.localdomain>

Even though "--get-regex" appears to work with "git config", the clear standard is to spell out the action in full.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---

this is the only occurrence i saw of this in the entire code base, so it seemed worth tweaking just for consistency.

diff --git a/t/perf/run b/t/perf/run
index 9aaa733c7..fb5753ea2 100755
--- a/t/perf/run
+++ b/t/perf/run
@@ -110,7 +110,7 @@ run_dirs () {
 get_subsections () {
 	section="$1"
 	test -z "$GIT_PERF_CONFIG_FILE" && return
-	git config -f "$GIT_PERF_CONFIG_FILE" --name-only --get-regex "$section\..*\.[^.]+" |
+	git config -f "$GIT_PERF_CONFIG_FILE" --name-only --get-regexp "$section\..*\.[^.]+" |
 	sed -e "s/$section\.\(.*\)\..*/\1/" | sort | uniq
 }
-- 
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                  http://crashcourse.ca/dokuwiki

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
Next: Thomas Gummerer
Message 1 of 6 in “t/perf/run: Use proper "--get-regexp", not "--get-regex"”
  1. t/perf/run: Use proper "--get-regexp", not "--get-regex"Robert P. J. Day, Jun 3, 2018
  2. Thomas GummererJun 3, 2018
  3. Robert P. J. DayJun 3, 2018
  4. Philip OakleyJun 3, 2018
  5. Robert P. J. DayJun 4, 2018
  6. Junio C HamanoJun 4, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.