git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pack-objects: no crc check when the cached version is used

From
Nicolas Pitre <nico@fluxnic.net>
Date
Sep 14, 2013, 03:18 UTC
Message-ID
<alpine.LFD.2.03.1309132302350.20709@syhkavp.arg>
In-Reply-To
<CACsJy8BctT3C+oW9a5azzFUru89j-NZ-kGK_wgxhsjRZEKnq_g@mail.gmail.com>
On Sat, 14 Sep 2013, Duy Nguyen wrote:
Show 6 quoted lines
> On Sat, Sep 14, 2013 at 4:26 AM, Thomas Rast <trast@inf.ethz.ch> wrote:
> > I tried the perf script below, but at least for the git repo the only
> > thing I can see is noise.
> 
> --stdout does not set do_check_packed_object_crc, you need to run
> pack-objects without --stdout (i.e. the real use case is repack)

And for those who might wonder why, you can have a look at the description for commit 0e8189e2708b. This was probably one of my best commit logs ever. ;-)

This commit also provides a hint about the cost of over-checking the CRC.

Nicolas
Previous: Duy Nguyen
Message 5 of 5 in “pack-objects: no crc check when the cached version is used”
  1. pack-objects: no crc check when the cached version is usedNguyễn Thái Ngọc Duy, Sep 13, 2013
  2. Junio C HamanoSep 13, 2013
  3. Thomas RastSep 13, 2013
  4. Duy NguyenSep 14, 2013
  5. Nicolas PitreSep 14, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.