Re: duplicate objects in packfile

From: Nicolas Pitre <nico@fluxnic.net>
Date: Aug 14, 2013, 18:54 UTC
Message-ID: <alpine.LFD.2.03.1308141451200.14472@syhkavp.arg>
In-Reply-To: <7vvc38ruah.fsf@alter.siamese.dyndns.org>

On Wed, 14 Aug 2013, Junio C Hamano wrote:

Show 8 quoted lines

> Also repacking may have a funny corner case. I do not recall the
> details as the above was a long time ago, but when I was tracking it
> down, a delta was made against one copy of the base object, and
> referred to it using delta-offset, while there was another copy of
> the base object which was found by the bisection search, and from
> there on, the inconsistencies between these two (they represent the
> same payload, but they are at different offsets in the same pack and
> with different in-pack sizes) led to some funky behaviour.

Crap.

Better try to cope with this (with a test case, etc.) rather than rejecting them now I'd say. Strictly speaking, they're still valid pack files.

Nicolas