Re: gc --aggressive

From: Nicolas Pitre <nico@fluxnic.net>
Date: May 1, 2012, 20:02 UTC
Message-ID: <alpine.LFD.2.02.1205011547060.21030@xanadu.home>
In-Reply-To: <20120501193537.GA26245@sigill.intra.peff.net>

On Tue, 1 May 2012, Jeff King wrote:

Show 10 quoted lines

> On Tue, May 01, 2012 at 01:59:08PM -0400, Nicolas Pitre wrote:
> 
> > One final quick test if you feel like it: I've never been sure that 
> > the last comparison in type_size_sort() is correct.  Maybe it should be 
> > the other way around.  Currently it reads:
> > 
> > 	return a < b ? -1 : (a > b);
> 
> I think it is right. At least it should put recent things near the
> front of the array, just as we are putting bigger things there.

Right. In fact, it seems that _I_ did think about it *five* years ago (man... time flies by) given commit adcc70950e, and then I reversed the whole order in commit b904166ccb to get what we have today.

Show 6 quoted lines

> > replace this line with:
> > 
> > 	return b < a ? -1 : (b > a);
> 
> No, it's not better. A few of the pack sizes are better, but some of
> them are worse. And the CPU times are still quite bad.

OK.  We can scratch that.

Nicolas