[PATCH 1/3] dir.c: clean up handling of 'path' parameter in read_directory_recursive()
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- May 14, 2009, 20:42 UTC
- Message-ID
- <alpine.LFD.2.01.0905141341470.3343@localhost.localdomain>
From: Linus Torvalds <torvalds@linux-foundation.org> Date: Thu, 14 May 2009 13:05:03 -0700
Right now we pass two different pathnames ('path' and 'base') down to read_directory_recursive(), and the only real reason for that is that we want to allow an empty 'base' parameter, but when we do so, we need the pathname to "opendir()" to be "." rather than the empty string.
And rather than handle that confusion in the caller, we can just fix read_directory_recursive() to handle the case of an empty path itself, by just passing opendir() a "." ourselves if the path is empty.
This would allow us to then drop one of the pathnames entirely from the calling convention, but rather than do that, we'll start separating them out as a "filesystem pathname" (the one we use for filesystem accesses) and a "git internal base name" (which is the name that we use for git internally).
That will eventually allow us to do things like handle different encodings (eg the filesystem pathnames might be Latin1, while git itself would use UTF-8 for filename information).
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> ---
This is a truly trivial diff, but it's independent from the other changes I have, and simplifies the next ones, so I've made it a patch of its own.
dir.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/dir.c b/dir.c index 6aae09a..0e6b752 100644 --- a/dir.c +++ b/dir.c @@ -576,7 +576,7 @@ static int get_dtype(struct dirent *de, const char *path) */ static int read_directory_recursive(struct dir_struct *dir, const char *path, const char *base, int baselen, int check_only, const struct path_simplify *simplify) { - DIR *fdir = opendir(path); + DIR *fdir = opendir(*path ? path : "."); int contents = 0; if (fdir) {
-- 1.6.3.1.11.g97114