git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http-backend: Don't infinite loop during die()

From
Nicolas Pitre <nico@fluxnic.net>
Date
Mar 24, 2010, 20:24 UTC
Message-ID
<alpine.LFD.2.00.1003241623370.694@xanadu.home>
In-Reply-To
<20100324200658.GA22505@spearce.org>
On Wed, 24 Mar 2010, Shawn O. Pearce wrote:
Show 19 quoted lines
> Junio C Hamano <gitster@pobox.com> wrote:
> > "Shawn O. Pearce" <spearce@spearce.org> writes:
> > 
> > > If stdout has already been closed by the CGI and die() gets called,
> > > the CGI will fail to write the "Status: 500 Internal Server Error" to
> > > the pipe, which results in die() being called again (via safe_write).
> > > This goes on in an infinite loop until the stack overflows and the
> > > process is killed by SIGSEGV.
> > >
> > > Instead set a flag on the first die() invocation and perform no
> > > action during recursive die() calls.  This way failures to write the
> > > error messages to the stdout pipe do not result in an infinite loop.
> > 
> > Hmm.  I would need something like this on top, but there must be a better
> > way.  Ideas?
> 
> Ick.
> 
> Just exit(0) if dead is true.
Do you really want the exit code to be 0 if you're dying?
Nicolas
Previous: Shawn O. PearceNext: Shawn Pearce
Message 7 of 9 in “git clone over smart-http hanging for just one repo.”
  1. Brady CathermanMar 22, 2010
  2. Shawn O. PearceMar 22, 2010
  3. http-backend: Don't infinite loop during die()Shawn O. Pearce, Mar 22, 2010
  4. Junio C HamanoMar 22, 2010
  5. Junio C HamanoMar 24, 2010
  6. Shawn O. PearceMar 24, 2010
  7. Nicolas PitreMar 24, 2010
  8. Shawn PearceMar 24, 2010
  9. Junio C HamanoMar 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.