Re: Remove diff machinery dependency from read-cache

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Jan 21, 2010, 20:15 UTC
Message-ID: <alpine.LFD.2.00.1001211215080.13231@localhost.localdomain>
In-Reply-To: <7vljfrp6g2.fsf@alter.siamese.dyndns.org>

On Thu, 21 Jan 2010, Junio C Hamano wrote:

Show 6 quoted lines

> 
> The patch itself to move add_files_to_cache() to builtin-add.c (or to its
> own file) makes sense from the code placement POV, but if the goal is to
> shrink the on-disk footprint, isn't an alternative approach be to make
> hash-object built-in?  You can lose the whole 1.7M from the filesystem
> footprint that way, no?

Sure. Except, as I mentioned, it's not just git-hash-object. It's _all_ of them.

The total space savings wasn't 1.7M, it was 12M.

		Linus