Re: Allow users to un-configure rename detection
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- Apr 9, 2009, 19:40 UTC
- Message-ID
- <alpine.LFD.2.00.0904091232420.4583@localhost.localdomain>
- In-Reply-To
- <alpine.LFD.2.00.0904091141420.4583@localhost.localdomain>
On Thu, 9 Apr 2009, Linus Torvalds wrote:
> > [diff] > renames = no
Btw, while doing this, I also though that "renames = on/off" made more sense, but while we allow yes/no and true/false for booleans, we don't allow on/off.
Should we? Maybe. Here's a stupid patch.
Linus
--- config.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/config.c b/config.c index b76fe4c..e7d91f5 100644 --- a/config.c +++ b/config.c @@ -331,9 +331,9 @@ int git_config_bool_or_int(const char *name, const char *value, int *is_bool) return 1; if (!*value) return 0; - if (!strcasecmp(value, "true") || !strcasecmp(value, "yes")) + if (!strcasecmp(value, "true") || !strcasecmp(value, "yes") || !strcasecmp(value, "on")) return 1; - if (!strcasecmp(value, "false") || !strcasecmp(value, "no")) + if (!strcasecmp(value, "false") || !strcasecmp(value, "no") || !strcasecmp(value, "off")) return 0; *is_bool = 0; return git_config_int(name, value);