Re: [PATCH] avoid possible overflow in delta size filtering computation

From: Nicolas Pitre <nico@cam.org>
Date: Mar 25, 2009, 19:17 UTC
Message-ID: <alpine.LFD.2.00.0903251514360.26337@xanadu.home>
In-Reply-To: <86bprptvcx.fsf@broadpark.no>

On Wed, 25 Mar 2009, Kjetil Barvik wrote:

Show 22 quoted lines

> Nicolas Pitre <nico@cam.org> writes:
> 
> > On Wed, 25 Mar 2009, Kjetil Barvik wrote:
> >
> >>   So, it seems that this patch almost fixed the issue.  But notice that
> >>   the pack file was 10 bytes larger for the --depth=95000 case.
> >> 
> >>   I made a small perl script to compare the output from 'git verify-pack
> >>   -v' of the 2 idx/pack files, and found the following difference(1)
> >>   (first line from --depth=20000 case, second from --depth=95000):
> >> 
> >>   fe0a6f3e971373590714dbafd087b235ea60ac00  tree   9  19  18921247  731  96a3ec5789504e6d0f90c99fb1937af1ebd58e2d
> >>   fe0a6f3e971373590714dbafd087b235ea60ac00  tree  20  29  18921247  730  12e560f7fb28558b15e3a2008fba860f9a4b2222
> >
> > OK.  Apparently, a different base object for that one delta was chosen 
> > between those two runs.
> >
> > Is your machine SMP?
> 
>   kjetil ~$ uname -a
>   Linux localhost 2.6.28.4 #26 SMP PREEMPT Tue Feb 10 17:07:14 CET 2009
>   i686 Intel(R) Core(TM)2 CPU T7200 @ 2.00GHz GenuineIntel GNU/Linux

Here you go. If you want a perfectly deterministic repacking, you'll have to force the pack.threads config option to 1.

Nicolas