Re: [PATCH] bash completion: Fix the . -> .. revision range completion
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- Jul 14, 2008, 05:38 UTC
- Message-ID
- <alpine.LFD.1.10.0807132210430.3305@woody.linux-foundation.org>
- In-Reply-To
- <20080714000021.GB13066@spearce.org>
On Mon, 14 Jul 2008, Shawn O. Pearce wrote:
Show 15 quoted lines
> > > > Does it fix this one too: > > > > git show origin/pu:Makef<tab> > > > > which totally screws up and becomes > > > > git show Makefile > > > > dropping the version specifier? > > Its unrelated to the issue you described above. But I just tested > your Makefile completion case and it worked as expected, though > I just found out it doesn't add a trailing space once there is a > unique completion made. I'll look at another patch to fix that.
What version of bash do you have?
It definitely doesn't work for me with
GNU bash, version 3.2.33(1)-release (x86_64-redhat-linux-gnu)
and quite frankly, I don't see how it _can_ work.
Something like this seems to be totally missing, and definitely required. How can you say that it works for you? I don't see how that is possible even in theory? Did you actually test it?
Linus
--- contrib/completion/git-completion.bash | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 27332ed..0a87337 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -290,7 +290,7 @@ __git_complete_file () ls="$ref" ;; esac - COMPREPLY=($(compgen -P "$pfx" \ + COMPREPLY=($(compgen -P "$ref:$pfx" \ -W "$(git --git-dir="$(__gitdir)" ls-tree "$ls" \ | sed '/^100... blob /s,^.* ,, /^040000 tree /{