git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] git-imap-send: Add support for SSL.

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Jul 10, 2008, 01:31 UTC
Message-ID
<alpine.LFD.1.10.0807091825500.11076@woody.linux-foundation.org>
In-Reply-To
<7v8wwa5ycf.fsf@gitster.siamese.dyndns.org>
On Wed, 9 Jul 2008, Junio C Hamano wrote:
> 
> A hack like the one attached below would make it "work" but it is too
> ugly.  Probably we need to bite the bullet and rename ours not to
> collide, so that external library headers can safely include <ctype.h>.
We should be able to safely include <ctype.h> as-is.

It should just happen _before_ including git-compat-util.h. That's why git-compat-util.h does all those #undef's - exactly because ctype.h does get included on various systems by various header files when git-compat-util.h includes all those other files.

So the problem with Robert's patch is that it happens after "cache.h". The system headers should be included at the top of git-compat-util.h, or before it.

		Linus
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 5 in “git-imap-send: Add support for SSL.”
  1. 2/4 git-imap-send: Add support for SSL.Robert Shearman, Jul 9, 2008
  2. Junio C HamanoJul 10, 2008
  3. Linus TorvaldsJul 10, 2008
  4. Junio C HamanoJul 10, 2008
  5. Mike HommeyJul 10, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.