Re: 'setup_work_tree()' considered harmful
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- Jun 18, 2008, 16:26 UTC
- Message-ID
- <alpine.LFD.1.10.0806180924170.2907@woody.linux-foundation.org>
- In-Reply-To
- <20080618090527.GA24254@glandium.org>
On Wed, 18 Jun 2008, Mike Hommey wrote:
> > Maybe using openat, fstatat, etc. when they are available, could be a > good thing, already, though it wouldn't help for other platforms.
I agree that openat() and friends would be nice for this (use a file descriptor instead of a string to point to object directories etc), but it's unportable enough that the pain of having to have two totally different access routines is just not worth it. It could be done, but it would need some really nifty abstraction layer.
We do already have _part_ of that abstraction layer with things like "git_path()" etc, but it would have to be extended upon quite a bit.
Linus