git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pack-objects: proper pack time stamping with --max-pack-size

From
Nicolas Pitre <nico@cam.org>
Date
Mar 14, 2008, 04:39 UTC
Message-ID
<alpine.LFD.1.00.0803140035260.2947@xanadu.home>
In-Reply-To
<7vmyp1vsa7.fsf@gitster.siamese.dyndns.org>
On Thu, 13 Mar 2008, Junio C Hamano wrote:
Show 24 quoted lines
> Nicolas Pitre <nico@cam.org> writes:
> 
> > Runtime pack access is done in the pack file mtime order since recent 
> > packs are more likely to contain frequently used objects than old packs.
> > However the --max-pack-size option can produce multiple packs with mtime 
> > in the reversed order as newer objects are always written first.
> >
> > Let's modify mtime of later pack files (when any) so they appear older 
> > than preceding ones when a repack creates multiple packs.
> >
> > Signed-off-by: Nicolas Pitre <nico@cam.org>
> > ---
> > diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
> > index f504cff..4c2ed70 100644
> > --- a/builtin-pack-objects.c
> > +++ b/builtin-pack-objects.c
> > @@ -17,6 +17,8 @@
> >  #include "progress.h"
> >  #include "refs.h"
> >  
> > +#include <utime.h>
> > +
> 
> Hmmm.  Shouldn't this go to git-compat-util.h?
Maybe... if you say so.

The whole header file arrangement logic is somewhat escaping my mind, so I simply decided to do the same as in test-chmtime.c.

Nicolas
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 5 in “pack-objects: proper pack time stamping with --max-pack-size”
  1. pack-objects: proper pack time stamping with --max-pack-sizeNicolas Pitre, Mar 13, 2008
  2. Junio C HamanoMar 13, 2008
  3. Junio C HamanoMar 14, 2008
  4. Nicolas PitreMar 14, 2008
  5. Junio C HamanoMar 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.