git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] xdl_merge(): introduce XDL_MERGE_ZEALOUS_ALNUM

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Feb 15, 2008, 18:17 UTC
Message-ID
<alpine.LFD.1.00.0802151012380.3066@woody.linux-foundation.org>
In-Reply-To
<7vlk5mgm5y.fsf@gitster.siamese.dyndns.org>
On Fri, 15 Feb 2008, Junio C Hamano wrote:
> 
> I think there is no excuse not to coalesce hunks separated by
> three lines or less

Well, I think the two line limit is the "unquestionable" one, since that's the one that actually results in fewer lines over-all.

The three-line case gets a bit less obvious since the line count doesn't change, and if the unchanged lines are complex, it might well be better to leave them as shared. What's not uncommon at all is that you have a small change that results in a new variable or similar, and then it's quite possible that the first conflict comes from a new variable declaration, and the second conflict is the "real code" change, and if there are three complex lines in between, it probably makes sense to keep them unmodified, and have two much simpler choices.

In fact, in many ways, maybe we'd be better off counting (non-space) bytes rather than lines. That gets the "complexity" argument mostly right.

			Linus
Previous: Junio C HamanoNext: Johannes Schindelin
Message 10 of 23 in “Merge-Recursive Improvements”
  1. Voltage SpikeFeb 12, 2008
  2. Stefan MonnierFeb 12, 2008
  3. Junio C HamanoFeb 12, 2008
  4. Linus TorvaldsFeb 12, 2008
  5. Johannes SchindelinFeb 13, 2008
  6. xdl_merge(): introduce XDL_MERGE_ZEALOUS_ALNUMJohannes Schindelin, Feb 13, 2008
  7. Junio C HamanoFeb 13, 2008
  8. Johannes SchindelinFeb 13, 2008
  9. Junio C HamanoFeb 15, 2008
  10. Linus TorvaldsFeb 15, 2008
  11. Johannes SchindelinFeb 15, 2008
  12. Johannes SchindelinFeb 17, 2008
  13. 1/2 xdl_merge(): make XDL_MERGE_ZEALOUS output simplerJohannes Schindelin, Feb 17, 2008
  14. 2/2 xdl_merge(): introduce XDL_MERGE_ZEALOUS_ALNUMJohannes Schindelin, Feb 17, 2008
  15. Junio C HamanoFeb 18, 2008
  16. Johannes SchindelinFeb 18, 2008
  17. Linus TorvaldsFeb 13, 2008
  18. Johannes SchindelinFeb 13, 2008
  19. Johannes SixtFeb 13, 2008
  20. Steffen ProhaskaFeb 13, 2008
  21. Voltage SpikeFeb 13, 2008
  22. Johannes SixtFeb 13, 2008
  23. Junio C HamanoFeb 15, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.