Re: [PATCH] receive-pack: check object type of sha1 before using them as commits

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Jan 2, 2008, 22:21 UTC
Message-ID: <alpine.LFD.1.00.0801021418510.3010@woody.linux-foundation.org>
In-Reply-To: <11992595612601-git-send-email-mkoegler@auto.tuwien.ac.at>

On Wed, 2 Jan 2008, Martin Koegler wrote:

Show 5 quoted lines

>  
> -		old_commit = (struct commit *)parse_object(old_sha1);
> -		new_commit = (struct commit *)parse_object(new_sha1);
> +		old_object = parse_object(old_sha1);
> +		new_object = parse_object(new_sha1);

I think it would be better to use

	old_object = lookup_commit_reference(old_sha1);
	if (!old_object)
		return "bad ref";
	new_object = lookup_commit_reference(new_sha1);
	if (!new_object)
		return "bad ref";

which will write a slightly more useful error message if it's not a commit (ie it will use the "check_commit()" function in commit.c)

		Linus