git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH WIP] sha1-lookup: make selection of 'middle' less aggressive

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Dec 30, 2007, 19:58 UTC
Message-ID
<alpine.LFD.1.00.0712301150120.32517@woody.linux-foundation.org>
In-Reply-To
<7vtzm08l9w.fsf@gitster.siamese.dyndns.org>
On Sun, 30 Dec 2007, Junio C Hamano wrote:
Show 5 quoted lines
> 
> With this patch, we actually see slight improvements in
> execution time as well.  In the same partial kde repository
> (3.0GB pack, 95MB idx; the numbers are from the same machine as
> before, best of 5 runs):

Ok, I tried this a year ago, and never got any real improvement. And mine was buggy. See

	http://marc.info/?l=git&m=117537594112450&w=2

and I decided it wasn't worth it. Yours looks much better, and seems to get a real performance improvement, so go for it, but I doubt that the actual object lookup is really ever the main issue. I've never seen it stand out in the real profiles, although if it is able to cut down on IO (and your minor fault numbers are promising!), it might be more important than I'd otherwise think.

		Linus
Previous: Shawn O. PearceNext: Junio C Hamano
Message 6 of 14 in “sha1-lookup: more memory efficient search in sorted list of SHA-1”
  1. sha1-lookup: more memory efficient search in sorted list of SHA-1Junio C Hamano, Dec 30, 2007
  2. sha1-lookup: make selection of 'middle' less aggressiveJunio C Hamano, Dec 30, 2007
  3. Marco CostalbaDec 30, 2007
  4. Marco CostalbaDec 30, 2007
  5. Shawn O. PearceDec 31, 2007
  6. Linus TorvaldsDec 30, 2007
  7. Junio C HamanoDec 30, 2007
  8. Marco CostalbaDec 30, 2007
  9. Linus TorvaldsDec 31, 2007
  10. Marco CostalbaDec 31, 2007
  11. Jeff KingJan 1, 2008
  12. Marco CostalbaJan 1, 2008
  13. Marco CostalbaJan 1, 2008
  14. Pierre HabouzitJan 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.