Re: That new progress meter

From: Nicolas Pitre <nico@cam.org>
Date: Nov 3, 2007, 14:53 UTC
Message-ID: <alpine.LFD.0.9999.0711031042390.21255@xanadu.home>
In-Reply-To: <20071103120953.GC13417@artemis.corp>

On Sat, 3 Nov 2007, Pierre Habouzit wrote:

Show 15 quoted lines

> On Fri, Nov 02, 2007 at 06:36:35PM +0000, Johannes Schindelin wrote:
> > Hi Nico,
> > 
> > that new progress meter sure is amazing and useful!
> 
>   I do agree. There seems to be some glitches though, here is how my
> output looks after a git fetch I just did on git.git:
> 
>     remote: Generating pack...
>     remote: Done counting 310 objects.
>     remote: Deltifying 310 objects...           | Here we have a glitch |
>     remote:  100% (310/310) done                 `-------vvvv----------'
>     remote: Total 310 (delta 160), reused 178 (delta 112)iB/s
>     Receiving objects: 100% (310/310), 379.98 KiB | 136 KiB/s, done.
>     Resolving deltas: 100% (160/160), done.

I know. This is why i TRIED TO KEEP THE "Receiving objects" line as short as possible.

Show 5 quoted lines

> FWIW, maybe instead using spaces to erase lines we could use minimal
> vt100 codes[0] like:
> 
> Erase End of Line       <ESC>[K
>     Erases from the current cursor position to the end of the current line.

I thought about that too, but this is not perfectly portable to all terminals according to a quick glance at /etc/termcap. Does the Windows console support it? Also we might prefer not to rely on termcap/terminfo library calls.

The other solution is to make the remote object summary line a bit longer, but this will be effective only when remote servers are upgraded. Might that be good enough?

Nicolas