Re: [PATCH 1/2] add throughput to progress display

From: Nicolas Pitre <nico@cam.org>
Date: Oct 30, 2007, 13:43 UTC
Message-ID: <alpine.LFD.0.9999.0710300935330.21255@xanadu.home>
In-Reply-To: <7vr6jdm2eb.fsf@gitster.siamese.dyndns.org>

On Tue, 30 Oct 2007, Junio C Hamano wrote:

> Very nice.
> 
> I however wonder why this breaks t1004 when applied on top of
> lt/rename topic.

Well... sh*t happens.

Could you please simply amend [PATCH 1/2] with the patch below:

diff --git a/progress.c b/progress.c
index d2460dd..a388e54 100644
--- a/progress.c
+++ b/progress.c
@@ -143,6 +143,7 @@ void start_progress_delay(struct progress *progress, const char *title,
 	progress->last_percent = -1;
 	progress->delayed_percent_treshold = percent_treshold;
 	progress->delay = delay;
+	progress->throughput = NULL;
 	set_progress_signal();
 }
 
@@ -160,5 +161,4 @@ void stop_progress(struct progress *progress)
 	}
 	clear_progress_signal();
 	free(progress->throughput);
-	progress->throughput = NULL;
 }


Nicolas