git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff-delta.c: rename {a,}{entry,hash} to {,u}{entry,hash}

From
Nicolas Pitre <nico@cam.org>
Date
Sep 8, 2007, 20:52 UTC
Message-ID
<alpine.LFD.0.9999.0709081648281.21186@xanadu.home>
In-Reply-To
<f1161c08aeeca60b6c33af34ccea68fd99b9ea4e.1189243702.git.dak@gnu.org>
On Sat, 8 Sep 2007, David Kastrup wrote:
Show 6 quoted lines
> The variables for the packed entries are now called just entry and
> hash rather than aentry+ahash, and those for the unpacked entries have
> been renamed to uentry and uhash from the original entry and hash.
> 
> While this makes the diff to the unchanged code larger, it matches the
> type declarations better.

Since the packed version is used less often, could you rename that one instead, and use packed_entry and packed_hash forclarity.

Also please fold this with your other patch (not the culling one).
Then you can add my ACK.
Nicolas
Previous: David KastrupNext: David Kastrup
Message 4 of 6 in “diff-delta.c: pack the index structure”
  1. diff-delta.c: pack the index structureDavid Kastrup, Sep 8, 2007
  2. diff-delta.c: rename {a,}{entry,hash} to {,u}{entry,hash}David Kastrup, Sep 8, 2007
  3. diff-delta.c: Rationalize culling of hash bucketsDavid Kastrup, Sep 8, 2007
  4. Nicolas PitreSep 8, 2007
  5. David KastrupSep 8, 2007
  6. Nicolas PitreSep 9, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.